Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore(legacy-chart-nvd3): convert nvd3 to emotion style #692

Merged
merged 3 commits into from
Aug 24, 2020
Merged

chore(legacy-chart-nvd3): convert nvd3 to emotion style #692

merged 3 commits into from
Aug 24, 2020

Conversation

pkdotson
Copy link
Contributor

💔 Breaking Changes

🏆 Enhancements
before

0 Superset  Security

image

image

image

image

image
image
image
image


after
image
image
image
image
image
image








📜 Documentation

🐛 Bug Fix

🏠 Internal

@pkdotson pkdotson requested a review from a team as a code owner July 20, 2020 21:28
@vercel
Copy link

vercel bot commented Jul 20, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/kko1509vi
✅ Preview: https://superset-ui-git-fork-preset-io-phillip-nvd-styles.superset.vercel.app

@codecov
Copy link

codecov bot commented Jul 20, 2020 •
edited
Loading

Codecov Report

Merging #692 into master will increase coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
+ Coverage   24.04%   24.15%   +0.10%     
==========================================
  Files         338      339       +1     
  Lines        7590     7631      +41     
  Branches      918      926       +8     
==========================================
+ Hits         1825     1843      +18     
- Misses       5692     5715      +23     
  Partials       73       73
Impacted Files Coverage Δ
plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js 0.00% <ø> (ø)
plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx 0.00% <0.00%> (ø)
...ugin-chart-table/src/DataTable/hooks/useSticky.tsx 3.57% <0.00%> (-0.09%) ⬇️
packages/superset-ui-query/src/processFilters.ts 100.00% <0.00%> (ø)
packages/superset-ui-query/src/buildQueryObject.ts 100.00% <0.00%> (ø)
...kages/superset-ui-query/src/types/QueryFormData.ts 100.00% <0.00%> (ø)
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <0.00%> (ø)
...s/plugin-chart-word-cloud/src/plugin/buildQuery.ts 100.00% <0.00%> (ø)
...rt-parallel-coordinates/src/ParallelCoordinates.js 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d700aa...ac871e0. Read the comment docs.

rusackas
rusackas approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

rusackas
rusackas suggested changes Jul 26, 2020
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think there's some duplicate code here.

plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx Outdated Show resolved Hide resolved
@pkdotson pkdotson requested a review from rusackas July 28, 2020 04:33
@rusackas rusackas merged commit 5f090ff into apache-superset:master Aug 24, 2020
@rusackas rusackas deleted the phillip/nvd-styles branch August 24, 2020 21:11
This was referenced Dec 15, 2021
Open
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkdotson @rusackas